Add pins of dune-project to Dyn representation #11187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Dec 7, 2024
gridbugs
approved these changes
Dec 9, 2024
Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
dune-project-source-dyn
branch
from
03284e3 to
1f08930
Compare
asymmetric
pushed a commit
to asymmetric/dune
that referenced
this pull request
Dec 9, 2024
Signed-off-by: Marek Kubica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #11186 I noticed that the
Dyn.trepresentation ofDune_project.tdiscards the sources/pins, unlike theWorkspace.twhich converts them.This PR adds the code to call the right conversion function, which already exists.